error prints when error is not NULL 91/71591/2 accepted/tizen/common/20160527.152739 accepted/tizen/ivi/20160527.052207 accepted/tizen/mobile/20160527.051702 submit/tizen/20160527.020259
authorJeesun Kim <iamjs.kim@samsung.com>
Thu, 26 May 2016 05:26:40 +0000 (14:26 +0900)
committerJeesun Kim <iamjs.kim@samsung.com>
Thu, 26 May 2016 06:57:18 +0000 (15:57 +0900)
Change-Id: I3a95efbacff8fbbc1cff225e1827b7cfe3c98e96

client/cal_client_dbus.c
server/cal_server_dbus.c

index 5d7d556..895ccfa 100644 (file)
@@ -179,8 +179,11 @@ int cal_dbus_start(void)
                        NULL,
                        &error);
        if (NULL == cal_dbus_object) {
-               ERR("cal_dbus_proxy_new_for_bus_sync() Fail[%s]", error->message);
-               g_error_free(error);
+               ERR("cal_dbus_proxy_new_for_bus_sync() Fail");
+               if (error) {
+                       ERR("error[%s]", error->message);
+                       g_error_free(error);
+               }
                return CALENDAR_ERROR_IPC;
        }
 
@@ -233,8 +236,11 @@ int cal_dbus_recovery(void)
                        NULL,
                        &error);
        if (NULL == cal_dbus_object) {
-               ERR("cal_dbus_proxy_new_for_bus_sync() Fail[%s]", error->message);
-               g_error_free(error);
+               ERR("cal_dbus_proxy_new_for_bus_sync() Fail");
+               if (error) {
+                       ERR("error[%s]", error->message);
+                       g_error_free(error);
+               }
                return CALENDAR_ERROR_IPC;
        }
 
index da795ff..55c8881 100644 (file)
@@ -734,8 +734,18 @@ int cal_dbus_emit_signal(const char *dest, const char *signal_name, GVariant *va
 
        calDbusSkeleton *skeleton = NULL;
        skeleton = CAL_DBUS_SKELETON(cal_dbus_get_object());
+       if (NULL == skeleton) {
+               ERR("cal_dbus_get_object() Fail");
+               return CALENDAR_ERROR_IPC;
+       }
+
        GDBusConnection *conn = NULL;
        conn = g_dbus_interface_skeleton_get_connection(G_DBUS_INTERFACE_SKELETON(skeleton));
+       if (NULL == conn) {
+               ERR("g_dbus_interface_skeleton_get_connection() Fail");
+               return CALENDAR_ERROR_IPC;
+       }
+
        ret = g_dbus_connection_emit_signal(conn,
                        dest,
                        CAL_DBUS_OBJPATH,
@@ -743,15 +753,22 @@ int cal_dbus_emit_signal(const char *dest, const char *signal_name, GVariant *va
                        signal_name,
                        value,
                        &error);
+
        if (FALSE == ret) {
-               ERR("g_dbus_connection_emit_signal() Fail(%s)", error->message);
-               g_error_free(error);
+               ERR("g_dbus_connection_emit_signal() Fail");
+               if (error) {
+                       ERR("error[%s]", error->message);
+                       g_error_free(error);
+               }
                return CALENDAR_ERROR_IPC;
        }
 
        if (FALSE == g_dbus_connection_flush_sync(conn, NULL, &error)) {
-               ERR("g_dbus_connection_flush_sync() Fail(%s)", error->message);
-               g_error_free(error);
+               ERR("g_dbus_connection_flush_sync() Fail");
+               if (error) {
+                       ERR("error[%s]", error->message);
+                       g_error_free(error);
+               }
                return CALENDAR_ERROR_IPC;
        }