media: aspeed: Extend debug message
authorJammy Huang <jammy_huang@aspeedtech.com>
Fri, 28 Oct 2022 02:35:54 +0000 (10:35 +0800)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 4 Nov 2022 15:56:42 +0000 (16:56 +0100)
updated as below:

Capture:
  Mode                : Direct fetch
  VGA bpp mode        : 32
  Signal              : lock
  Width               : 1920
  Height              : 1080
  FRC                 : 0

Compression:
  Format              : JPEG
  Subsampling         : 444
  Quality             : 4

Performance:
  Frame#              : 4
  Frame Duration(ms)  :
    Now               : 22
    Min               : 21
    Max               : 22
  FPS                 : 45

Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/aspeed/aspeed-video.c

index 482fa89..f08b788 100644 (file)
@@ -1904,9 +1904,29 @@ static const struct vb2_ops aspeed_video_vb2_ops = {
 static int aspeed_video_debugfs_show(struct seq_file *s, void *data)
 {
        struct aspeed_video *v = s->private;
+       u32 val08;
 
        seq_puts(s, "\n");
 
+       seq_puts(s, "Capture:\n");
+       val08 = aspeed_video_read(v, VE_CTRL);
+       if (FIELD_GET(VE_CTRL_DIRECT_FETCH, val08)) {
+               seq_printf(s, "  %-20s:\tDirect fetch\n", "Mode");
+               seq_printf(s, "  %-20s:\t%s\n", "VGA bpp mode",
+                          FIELD_GET(VE_CTRL_INT_DE, val08) ? "16" : "32");
+       } else {
+               seq_printf(s, "  %-20s:\tSync\n", "Mode");
+               seq_printf(s, "  %-20s:\t%s\n", "Video source",
+                          FIELD_GET(VE_CTRL_SOURCE, val08) ?
+                          "external" : "internal");
+               seq_printf(s, "  %-20s:\t%s\n", "DE source",
+                          FIELD_GET(VE_CTRL_INT_DE, val08) ?
+                          "internal" : "external");
+               seq_printf(s, "  %-20s:\t%s\n", "Cursor overlay",
+                          FIELD_GET(VE_CTRL_AUTO_OR_CURSOR, val08) ?
+                          "Without" : "With");
+       }
+
        seq_printf(s, "  %-20s:\t%s\n", "Signal",
                   v->v4l2_input_status ? "Unlock" : "Lock");
        seq_printf(s, "  %-20s:\t%d\n", "Width", v->pix_fmt.width);
@@ -1915,13 +1935,29 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data)
 
        seq_puts(s, "\n");
 
+       seq_puts(s, "Compression:\n");
+       seq_printf(s, "  %-20s:\t%s\n", "Format", format_str[v->format]);
+       seq_printf(s, "  %-20s:\t%s\n", "Subsampling",
+                  v->yuv420 ? "420" : "444");
+       seq_printf(s, "  %-20s:\t%d\n", "Quality", v->jpeg_quality);
+       if (v->format == VIDEO_FMT_ASPEED) {
+               seq_printf(s, "  %-20s:\t%s\n", "HQ Mode",
+                          v->hq_mode ? "on" : "off");
+               seq_printf(s, "  %-20s:\t%d\n", "HQ Quality",
+                          v->hq_mode ? v->jpeg_hq_quality : 0);
+       }
+
+       seq_puts(s, "\n");
+
        seq_puts(s, "Performance:\n");
        seq_printf(s, "  %-20s:\t%d\n", "Frame#", v->sequence);
        seq_printf(s, "  %-20s:\n", "Frame Duration(ms)");
        seq_printf(s, "    %-18s:\t%d\n", "Now", v->perf.duration);
        seq_printf(s, "    %-18s:\t%d\n", "Min", v->perf.duration_min);
        seq_printf(s, "    %-18s:\t%d\n", "Max", v->perf.duration_max);
-       seq_printf(s, "  %-20s:\t%d\n", "FPS", 1000 / (v->perf.totaltime / v->sequence));
+       seq_printf(s, "  %-20s:\t%d\n", "FPS",
+                  (v->perf.totaltime && v->sequence) ?
+                  1000 / (v->perf.totaltime / v->sequence) : 0);
 
        return 0;
 }