r8152: Release firmware if we have an error in probe

[ Upstream commit b8d35024d4059ca550cba11ac9ab23a6c238d929 ]

The error handling in rtl8152_probe() is missing a call to release
firmware. Add it in to match what's in the cleanup code in
rtl8152_disconnect().

Fixes: 9370f2d05a2a ("r8152: support request_firmware for RTL8153")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index fb9c1f3f6e5a42df823398e02a259744cf279919..c34974f7dfd26dca4ca673fcb8b04b3a1f048614 100644 (file)
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -9829,6 +9829,7 @@ out1:
        cancel_delayed_work_sync(&tp->hw_phy_work);
        if (tp->rtl_ops.unload)
                tp->rtl_ops.unload(tp);
+       rtl8152_release_firmware(tp);
        usb_set_intfdata(intf, NULL);
 out:
        free_netdev(netdev);