uridecodebin3: don't segfault if a pad is not a source pad when it is removed
authorhoonhee.lee <hoonhee.lee@lge.com>
Wed, 25 Apr 2018 00:28:53 +0000 (09:28 +0900)
committerEdward Hervey <bilboed@bilboed.com>
Tue, 1 May 2018 07:33:16 +0000 (09:33 +0200)
Ignore to handling a pad of decodebin3 which doesn't have corresponding output
when it is removed.

https://bugzilla.gnome.org/show_bug.cgi?id=795529

gst/playback/gsturidecodebin3.c

index 9b2147a..436e37c 100644 (file)
@@ -565,6 +565,9 @@ db_pad_removed_cb (GstElement * element, GstPad * pad, GstURIDecodeBin3 * dec)
   GList *tmp;
   OutputPad *output = NULL;
 
+  if (!GST_PAD_IS_SRC (pad))
+    return;
+
   GST_DEBUG_OBJECT (dec, "pad %s:%s", GST_DEBUG_PAD_NAME (pad));
   /* FIXME: LOCK for list access */