Fix cppcheck warnings

Fixing some found cppcheck warnings

Change-Id: I9dfb3477283661b9062977ac6a012b37f01d5041

diff --git a/parser/pkgmgr_parser.c b/parser/pkgmgr_parser.c
index 4d3ca2b..13e683a 100644 (file)
--- a/parser/pkgmgr_parser.c
+++ b/parser/pkgmgr_parser.c
@@ -2313,7 +2313,6 @@ API int pkgmgr_parser_process_manifest_x_for_upgrade(manifest_x* mfx, const char
        retvm_if(manifest == NULL, PMINFO_R_ERROR, "argument supplied is NULL");
        _LOGD("pkgmgr_parser_process_manifest_x_for_upgrade  parsing manifest for upgradation: %s\n", manifest);
        int ret = -1;
-       bool preload = false;
        bool system = false;
        char *csc_path = NULL;
        pkgmgrinfo_pkginfo_h handle = NULL;

diff --git a/parser/pkgmgr_parser_db.c b/parser/pkgmgr_parser_db.c
index 2761915..ec182da 100644 (file)
--- a/parser/pkgmgr_parser_db.c
+++ b/parser/pkgmgr_parser_db.c
@@ -384,6 +384,8 @@ static int __guestmode_visibility_cb(void *data, int ncols, char **coltxt, char
                }
        }
        if (appid == NULL) {
+               if(status != NULL)
+                       free(status);
                _LOGD("app id is NULL\n");
                return -1;
        }
@@ -1720,7 +1722,7 @@ API int pkgmgr_parser_initialize_db(uid_t uid)
        for (i = 0; columns[i] != NULL; i++) {
                snprintf(query, sizeof(query),
                                QUERY_CREATE_TRIGGER_UPDATE_CERT_INFO_FORMAT,
-                               columns[i], columns[i], columns[i], columns[i]);
+                               columns[i], columns[i], columns[i]);
                ret = __initialize_db(pkgmgr_cert_db, query);
                if (ret == -1) {
                        _LOGD("package cert index info DB initialization failed\n");

diff --git a/src/pkgmgrinfo_db.c b/src/pkgmgrinfo_db.c
index 5fce33b..cd59b40 100644 (file)
--- a/src/pkgmgrinfo_db.c
+++ b/src/pkgmgrinfo_db.c
@@ -203,7 +203,7 @@ int _check_create_cert_db(sqlite3 *certdb)
        for (i = 0; columns[i] != NULL; i++) {
                snprintf(buf, sizeof(buf),
                                QUERY_CREATE_TRIGGER_UPDATE_CERT_INFO_FORMAT,
-                               columns[i], columns[i], columns[i], columns[i]);
+                               columns[i], columns[i], columns[i]);
                ret = __exec_db_query(certdb, buf, NULL, NULL);
                if (ret < 0)
                        return ret;
@@ -633,7 +633,6 @@ API int pkgmgrinfo_pkginfo_set_usr_installed_storage(const char *pkgid, INSTALL_
 {
        retvm_if(pkgid == NULL, PMINFO_R_EINVAL, "pkgid is NULL\n");
        int ret = -1;
-       int exist = 0;
        sqlite3 *pkgmgr_parser_db = NULL;
        char *query = NULL;