projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f83c32e
)
nbd: Fix debugfs_create_dir error checking
author
Ivan Orlov
<ivan.orlov0322@gmail.com>
Fri, 12 May 2023 13:05:32 +0000
(17:05 +0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 9 Jun 2023 08:34:09 +0000
(10:34 +0200)
[ Upstream commit
4913cfcf014c95f0437db2df1734472fd3e15098
]
The debugfs_create_dir function returns ERR_PTR in case of error, and the
only correct way to check if an error occurred is 'IS_ERR' inline function.
This patch will replace the null-comparison with IS_ERR.
Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
Link:
https://lore.kernel.org/r/20230512130533.98709-1-ivan.orlov0322@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/block/nbd.c
patch
|
blob
|
history
diff --git
a/drivers/block/nbd.c
b/drivers/block/nbd.c
index
888a6ab
..
7718c81
100644
(file)
--- a/
drivers/block/nbd.c
+++ b/
drivers/block/nbd.c
@@
-1665,7
+1665,7
@@
static int nbd_dev_dbg_init(struct nbd_device *nbd)
return -EIO;
dir = debugfs_create_dir(nbd_name(nbd), nbd_dbg_dir);
- if (
!dir
) {
+ if (
IS_ERR(dir)
) {
dev_err(nbd_to_dev(nbd), "Failed to create debugfs dir for '%s'\n",
nbd_name(nbd));
return -EIO;
@@
-1691,7
+1691,7
@@
static int nbd_dbg_init(void)
struct dentry *dbg_dir;
dbg_dir = debugfs_create_dir("nbd", NULL);
- if (
!dbg_dir
)
+ if (
IS_ERR(dbg_dir)
)
return -EIO;
nbd_dbg_dir = dbg_dir;