drm/amd/display: Fix DMUB PSR command IDs
authorWyatt Wood <wyatt.wood@amd.com>
Wed, 18 Dec 2019 20:11:55 +0000 (15:11 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 16 Jan 2020 19:15:11 +0000 (14:15 -0500)
[Why]
The DMUB PSR command IDs do not have the correct values.

[How]
Fix the command IDs and cleanup the formatting.

Signed-off-by: Wyatt Wood <wyatt.wood@amd.com>
Reviewed-by: Aric Cyr <Aric.Cyr@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd_dal.h

index 20b4764..7b69eb3 100644 (file)
  */
 
 enum dmub_cmd_psr_type {
-       DMUB_CMD__PSR_ENABLE = 0,
-       DMUB_CMD__PSR_DISABLE = 1,
-       DMUB_CMD__PSR_COPY_SETTINGS = 2,
-       DMUB_CMD__PSR_SET_LEVEL = 3,
-       DMUB_CMD__PSR_SETUP = 4,
+       DMUB_CMD__PSR_SETUP             = 0,
+       DMUB_CMD__PSR_COPY_SETTINGS     = 1,
+       DMUB_CMD__PSR_ENABLE            = 2,
+       DMUB_CMD__PSR_DISABLE           = 3,
+       DMUB_CMD__PSR_SET_LEVEL         = 4,
 };
 
 enum psr_version {
-       PSR_VERSION_1 = 0x0,
-       PSR_VERSION_2 = 0x10,
+       PSR_VERSION_1                   = 0x10, // PSR Version 1
+       PSR_VERSION_2                   = 0x20, // PSR Version 2, includes selective update
+       PSR_VERSION_2_Y_COORD           = 0x21, // PSR Version 2, includes Y-coordinate support for SU
 };
 
 #endif /* _DMUB_CMD_DAL_H_ */