src: mark empty destructors as default

Mark empty destructors as having a default no-op implementation.
Remove a few unused constructors and destructors while we are here.

diff --git a/src/async-wrap-inl.h b/src/async-wrap-inl.h
index 6fad7eac36ce789e7fb5e97cf2e3b4624a1eb4c2..750466b3ddbba77c3c0e2bb84b0abb1612806770 100644 (file)
--- a/src/async-wrap-inl.h
+++ b/src/async-wrap-inl.h
@@ -54,9 +54,6 @@ inline AsyncWrap::AsyncWrap(Environment* env,
 }
 
 
-inline AsyncWrap::~AsyncWrap() {
-}
-
 inline uint32_t AsyncWrap::provider_type() const {
   return provider_type_;
 }

diff --git a/src/async-wrap.h b/src/async-wrap.h
index 1b1802a68ffc89c27c1047db8d247e8dec559ce2..a8577984ed04b73b45376f461316f1b08ffddf50 100644 (file)
--- a/src/async-wrap.h
+++ b/src/async-wrap.h
@@ -61,7 +61,7 @@ class AsyncWrap : public BaseObject {
                    v8::Handle<v8::Object> object,
                    ProviderType provider);
 
-  inline ~AsyncWrap();
+  inline ~AsyncWrap() = default;
 
   inline bool has_async_listener();
 

diff --git a/src/node.cc b/src/node.cc
index 6aaf3068274d5b707df78aec2a6f2fb6d98ace8b..4bcd62287a3f37e07a2b7bb1202df810b0bfa329 100644 (file)
--- a/src/node.cc
+++ b/src/node.cc
@@ -159,12 +159,12 @@ class ArrayBufferAllocator : public ArrayBuffer::Allocator {
   // the process.
   static const size_t kMaxLength = 0x3fffffff;
   static ArrayBufferAllocator the_singleton;
-  virtual ~ArrayBufferAllocator() {}
+  virtual ~ArrayBufferAllocator() = default;
   virtual void* Allocate(size_t length) override;
   virtual void* AllocateUninitialized(size_t length) override;
   virtual void Free(void* data, size_t length) override;
  private:
-  ArrayBufferAllocator() {}
+  ArrayBufferAllocator() = default;
   DISALLOW_COPY_AND_ASSIGN(ArrayBufferAllocator);
 };
 

diff --git a/src/node_crypto_clienthello.h b/src/node_crypto_clienthello.h
index 33048c2a60f88d302770bfe14284da898aa725d6..bbd46e5a312de1d0070d3622f172574e29e7966a 100644 (file)
--- a/src/node_crypto_clienthello.h
+++ b/src/node_crypto_clienthello.h
@@ -47,9 +47,6 @@ class ClientHelloParser {
 
   class ClientHello {
    public:
-    ClientHello() {
-    }
-
     inline uint8_t session_size() const { return session_size_; }
     inline const uint8_t* session_id() const { return session_id_; }
     inline bool has_ticket() const { return has_ticket_; }

diff --git a/src/node_v8_platform.cc b/src/node_v8_platform.cc
index 7439382bca171a536858e67717a69e89eba8b899..d71fdd4cc9fc5467eee59de23125fee2cc6d25c5 100644 (file)
--- a/src/node_v8_platform.cc
+++ b/src/node_v8_platform.cc
@@ -35,9 +35,6 @@ using v8::Isolate;
 // The last task to encounter before killing the worker
 class StopTask : public Task {
  public:
-  StopTask() {}
-  ~StopTask() {}
-
   void Run() {}
 };
 

diff --git a/src/process_wrap.cc b/src/process_wrap.cc
index 61cb6cff283e2e5d1d0340f62244cea46d74ae61..ab7d9bfddbf05a587631b10322854a0714f40e90 100644 (file)
--- a/src/process_wrap.cc
+++ b/src/process_wrap.cc
@@ -84,9 +84,6 @@ class ProcessWrap : public HandleWrap {
                    AsyncWrap::PROVIDER_PROCESSWRAP) {
   }
 
-  ~ProcessWrap() {
-  }
-
   static void ParseStdioOptions(Environment* env,
                                 Local<Object> js_options,
                                 uv_process_options_t* options) {

diff --git a/src/signal_wrap.cc b/src/signal_wrap.cc
index 1d32f7af0f06ac6fc1b4c304f7a87191bdf8a5fa..fbde1ca526e614a08ba562328094c6b4dbc178ca 100644 (file)
--- a/src/signal_wrap.cc
+++ b/src/signal_wrap.cc
@@ -80,9 +80,6 @@ class SignalWrap : public HandleWrap {
     CHECK_EQ(r, 0);
   }
 
-  ~SignalWrap() {
-  }
-
   static void Start(const FunctionCallbackInfo<Value>& args) {
     SignalWrap* wrap = Unwrap<SignalWrap>(args.Holder());
     int signum = args[0]->Int32Value();

diff --git a/src/stream_wrap.h b/src/stream_wrap.h
index 3c058d26f8a86c4255097d182881919d6222d285..dbb969a06c6fe685a2b9c8036e0cd3b912f2c8c6 100644 (file)
--- a/src/stream_wrap.h
+++ b/src/stream_wrap.h
@@ -72,8 +72,7 @@ class StreamWrapCallbacks {
   explicit StreamWrapCallbacks(StreamWrapCallbacks* old) : wrap_(old->wrap()) {
   }
 
-  virtual ~StreamWrapCallbacks() {
-  }
+  virtual ~StreamWrapCallbacks() = default;
 
   virtual const char* Error();
 

diff --git a/src/timer_wrap.cc b/src/timer_wrap.cc
index dfa551d05c56d214473f5022adc809f30a13a537..8ccdca5961126dc7f22883b0da9f8aa159b37d14 100644 (file)
--- a/src/timer_wrap.cc
+++ b/src/timer_wrap.cc
@@ -91,9 +91,6 @@ class TimerWrap : public HandleWrap {
     CHECK_EQ(r, 0);
   }
 
-  ~TimerWrap() {
-  }
-
   static void Start(const FunctionCallbackInfo<Value>& args) {
     TimerWrap* wrap = Unwrap<TimerWrap>(args.Holder());
 

diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc
index 1698ecf64542090ed086b1c91d50288503439f53..fa047eccc94ffbb7c54a29376afff570a0a1c3a7 100644 (file)
--- a/src/udp_wrap.cc
+++ b/src/udp_wrap.cc
@@ -82,10 +82,6 @@ UDPWrap::UDPWrap(Environment* env, Handle<Object> object)
 }
 
 
-UDPWrap::~UDPWrap() {
-}
-
-
 void UDPWrap::Initialize(Handle<Object> target,
                          Handle<Value> unused,
                          Handle<Context> context) {

diff --git a/src/udp_wrap.h b/src/udp_wrap.h
index 5d9cbef74693fe021aabafda4fcfce308347735c..fea298031ac02d8af2d5d31ba6a2c94bef531bc4 100644 (file)
--- a/src/udp_wrap.h
+++ b/src/udp_wrap.h
@@ -58,7 +58,6 @@ class UDPWrap: public HandleWrap {
 
  private:
   UDPWrap(Environment* env, v8::Handle<v8::Object> object);
-  virtual ~UDPWrap() override;
 
   static void DoBind(const v8::FunctionCallbackInfo<v8::Value>& args,
                      int family);