Input: small tweak to autorepeat handling
authorAnshul Garg <aksgarg1989@gmail.com>
Thu, 8 Jan 2015 21:41:24 +0000 (13:41 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 8 Jan 2015 21:53:30 +0000 (13:53 -0800)
If a device does not support autorepeat or does not emit any key events we
should not be scanning all events in a packet to decide if we should start
or stop autorepeat function.

Signed-off-by: Anshul Garg <anshul.g@samsung.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/input.c

index 213e3a1..26199ab 100644 (file)
@@ -152,12 +152,14 @@ static void input_pass_values(struct input_dev *dev,
        add_input_randomness(vals->type, vals->code, vals->value);
 
        /* trigger auto repeat for key events */
-       for (v = vals; v != vals + count; v++) {
-               if (v->type == EV_KEY && v->value != 2) {
-                       if (v->value)
-                               input_start_autorepeat(dev, v->code);
-                       else
-                               input_stop_autorepeat(dev);
+       if (test_bit(EV_REP, dev->evbit) && test_bit(EV_KEY, dev->evbit)) {
+               for (v = vals; v != vals + count; v++) {
+                       if (v->type == EV_KEY && v->value != 2) {
+                               if (v->value)
+                                       input_start_autorepeat(dev, v->code);
+                               else
+                                       input_stop_autorepeat(dev);
+                       }
                }
        }
 }