Choose the correct icon size for Windows taskbar
authorCheng Zhao <zcbenz@gmail.com>
Mon, 30 May 2016 00:46:42 +0000 (09:46 +0900)
committerCheng Zhao <zcbenz@gmail.com>
Mon, 30 May 2016 00:46:42 +0000 (09:46 +0900)
atom/browser/api/atom_api_window.cc
docs/api/native-image.md

index 122c5a6..ac3c510 100644 (file)
@@ -633,7 +633,8 @@ void Window::ShowDefinitionForSelection() {
 void Window::SetIcon(mate::Handle<NativeImage> icon) {
 #if defined(OS_WIN)
   static_cast<NativeWindowViews*>(window_.get())->SetIcon(
-      icon->GetHICON(GetSystemMetrics(SM_CXSMICON)), icon->GetHICON(256));
+      icon->GetHICON(GetSystemMetrics(SM_CXSMICON)),
+      icon->GetHICON(GetSystemMetrics(SM_CXICON)));
 #elif defined(USE_X11)
   static_cast<NativeWindowViews*>(window_.get())->SetIcon(
       icon->image().AsImageSkia());
index 9790daa..5244b71 100644 (file)
@@ -30,6 +30,7 @@ effects it is recommended to include at least followings sizes in the icon:
 
 * 16x16
 * 32x32
+* 64x64
 * 256x256
 
 ## High Resolution Image