Reenable checking for core ballot functions
authorGraeme Leese <gleese@broadcom.com>
Wed, 9 Oct 2019 09:31:55 +0000 (10:31 +0100)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Fri, 18 Oct 2019 09:09:35 +0000 (05:09 -0400)
All the subgroup ballot tests were mistakenly created as extension
tests, so none of them were testing the core functionality.

Components: Vulkan
Affect: dEQP-VK.subgroups.ballot.framebuffer.*

Change-Id: I2876ed3e04c831e90d7d605019cdcfd8ecb8e375

external/vulkancts/modules/vulkan/subgroups/vktSubgroupsBallotTests.cpp

index 822428d..18a7c7d 100755 (executable)
@@ -895,7 +895,6 @@ void initPrograms(SourceCollections& programCollection, CaseDefinition caseDef)
 
 void supportedCheck (Context& context, CaseDefinition caseDef)
 {
-       DE_UNREF(caseDef);
        if (!subgroups::isSubgroupSupported(context))
                TCU_THROW(NotSupportedError, "Subgroup operations are not supported");
 
@@ -1055,7 +1054,7 @@ tcu::TestCaseGroup* createSubgroupsBallotTests(tcu::TestContext& testCtx)
 
        for (int stageIndex = 0; stageIndex < DE_LENGTH_OF_ARRAY(stages); ++stageIndex)
        {
-               CaseDefinition caseDef = {stages[stageIndex],de::SharedPtr<bool>(new bool), DE_TRUE};
+               CaseDefinition caseDef = {stages[stageIndex],de::SharedPtr<bool>(new bool), DE_FALSE};
                addFunctionCaseWithPrograms(framebufferGroup.get(), getShaderStageName(caseDef.shaderStage), "",
                                        supportedCheck, initFrameBufferPrograms, noSSBOtest, caseDef);
                caseDef.extShaderSubGroupBallotTests = DE_TRUE;