powerpc/mm/slice: tidy lpsizes and hpsizes update loops
authorNicholas Piggin <npiggin@gmail.com>
Wed, 7 Mar 2018 01:37:10 +0000 (11:37 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 13 Mar 2018 12:43:05 +0000 (23:43 +1100)
Make these loops look the same, and change their form so the
important part is not wrapped over so many lines.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/mm/slice.c

index 7b51f96..432c328 100644 (file)
@@ -232,22 +232,24 @@ static void slice_convert(struct mm_struct *mm, struct slice_mask mask, int psiz
        spin_lock_irqsave(&slice_convert_lock, flags);
 
        lpsizes = mm->context.low_slices_psize;
-       for (i = 0; i < SLICE_NUM_LOW; i++)
-               if (mask.low_slices & (1u << i)) {
-                       mask_index = i & 0x1;
-                       index = i >> 1;
-                       lpsizes[index] = (lpsizes[index] &
-                                         ~(0xf << (mask_index * 4))) |
+       for (i = 0; i < SLICE_NUM_LOW; i++) {
+               if (!(mask.low_slices & (1u << i)))
+                       continue;
+
+               mask_index = i & 0x1;
+               index = i >> 1;
+               lpsizes[index] = (lpsizes[index] & ~(0xf << (mask_index * 4))) |
                                (((unsigned long)psize) << (mask_index * 4));
-               }
+       }
 
        hpsizes = mm->context.high_slices_psize;
        for (i = 0; i < GET_HIGH_SLICE_INDEX(mm->context.slb_addr_limit); i++) {
+               if (!test_bit(i, mask.high_slices))
+                       continue;
+
                mask_index = i & 0x1;
                index = i >> 1;
-               if (test_bit(i, mask.high_slices))
-                       hpsizes[index] = (hpsizes[index] &
-                                         ~(0xf << (mask_index * 4))) |
+               hpsizes[index] = (hpsizes[index] & ~(0xf << (mask_index * 4))) |
                                (((unsigned long)psize) << (mask_index * 4));
        }