elm theme - fix leak in error cse in elm theme mmap set
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Mon, 5 Aug 2019 13:28:40 +0000 (14:28 +0100)
committerJaehyun Cho <jae_hyun.cho@samsung.com>
Mon, 12 Aug 2019 07:20:56 +0000 (16:20 +0900)
we don't free the eina file handle on error. coverity found it. fix

fix CID 1402680

src/lib/elementary/elm_theme.c

index 4c35f18..fb33923 100644 (file)
@@ -651,7 +651,11 @@ elm_theme_overlay_mmap_add(Elm_Theme *th, const Eina_File *f)
    Eina_File *file = eina_file_dup(f);
 
    if (!th) th = theme_default;
-   if (!th) return;
+   if (!th)
+     {
+        eina_file_close(file);
+        return;
+     }
    th->overlay_items = eina_list_free(th->overlay_items);
    _elm_theme_item_finalize(&th->overlay, eina_file_filename_get(file), file, EINA_TRUE, EINA_FALSE);
    elm_theme_flush(th);