ASoC: soc-topology.c: add comment for Platform/Codec
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 24 Apr 2023 02:37:38 +0000 (02:37 +0000)
committerMark Brown <broonie@kernel.org>
Sun, 7 May 2023 23:47:15 +0000 (08:47 +0900)
Not only Platform but Codec also might be overwritten on Topology.
This patch adds comment about it not to use asoc_dummy_dlc here.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com
Link: https://lore.kernel.org/r/87sfcqyphq.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org
sound/soc/soc-topology.c

index d0aca6b..47ab5cf 100644 (file)
@@ -1693,10 +1693,7 @@ static int soc_tplg_fe_link_create(struct soc_tplg *tplg,
        dlc = (struct snd_soc_dai_link_component *)(link + 1);
 
        link->cpus      = &dlc[0];
-       link->codecs    = &dlc[1];
-
        link->num_cpus   = 1;
-       link->num_codecs = 1;
 
        link->dobj.index = tplg->index;
        link->dobj.type = SND_SOC_DOBJ_DAI_LINK;
@@ -1721,16 +1718,19 @@ static int soc_tplg_fe_link_create(struct soc_tplg *tplg,
                }
        }
 
-       link->codecs->name = "snd-soc-dummy";
-       link->codecs->dai_name = "snd-soc-dummy-dai";
-
        /*
-        * Many topology is assuming link has Platform.
-        * This might be overwritten at soc_tplg_dai_link_load().
+        * Many topology are assuming link has Codec / Platform, and
+        * these might be overwritten at soc_tplg_dai_link_load().
+        * Don't use &asoc_dummy_dlc here.
         */
-       link->platforms = &dlc[2];
-       link->platforms->name = "snd-soc-dummy";
-       link->num_platforms = 1;
+       link->codecs            = &dlc[1];      /* Don't use &asoc_dummy_dlc here */
+       link->codecs->name      = "snd-soc-dummy";
+       link->codecs->dai_name  = "snd-soc-dummy-dai";
+       link->num_codecs        = 1;
+
+       link->platforms         = &dlc[2];      /* Don't use &asoc_dummy_dlc here */
+       link->platforms->name   = "snd-soc-dummy";
+       link->num_platforms     = 1;
 
        /* enable DPCM */
        link->dynamic = 1;