staging: rts5208: Added value check
authorDenis Arefev <arefev@swemel.ru>
Fri, 18 Nov 2022 11:15:23 +0000 (14:15 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jan 2023 18:18:41 +0000 (19:18 +0100)
Added value check.
Return value of a function 'ms_set_rw_reg_addr'
called at ms.c:1770 is not checked,
but it is usually checked for this function

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Denis Arefev <arefev@swemel.ru>
Link: https://lore.kernel.org/r/20221118111523.123463-1-arefev@swemel.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rts5208/ms.c

index 14449f8..bfeb587 100644 (file)
@@ -1768,6 +1768,8 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk,
 
                retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG, MS_EXTRA_SIZE,
                                            SYSTEM_PARAM, (6 + MS_EXTRA_SIZE));
+               if (retval != STATUS_SUCCESS)
+                       return STATUS_FAIL;
 
                ms_set_err_code(chip, MS_NO_ERROR);