RDMA/drivers: Use dev_err/dbg/etc instead of pr_* + ibdev->name

Kernel convention is that a driver for a subsystem will print using
dev_* on the subsystem's struct device, or with dev_* on the physical
device. Drivers should rarely use a pr_* function.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
index 94cf83b..5ada28d 100644 (file)
--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h
+++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h
@@ -50,17 +50,17 @@
 #include <rdma/uverbs_ioctl.h>
 #include <rdma/mlx5_user_ioctl_cmds.h>
 
-#define mlx5_ib_dbg(dev, format, arg...)                               \
-pr_debug("%s:%s:%d:(pid %d): " format, (dev)->ib_dev.name, __func__,   \
-        __LINE__, current->pid, ##arg)
+#define mlx5_ib_dbg(_dev, format, arg...)                                      \
+       dev_dbg(&(_dev)->ib_dev.dev, "%s:%d:(pid %d): " format, __func__,      \
+               __LINE__, current->pid, ##arg)
 
-#define mlx5_ib_err(dev, format, arg...)                               \
-pr_err("%s:%s:%d:(pid %d): " format, (dev)->ib_dev.name, __func__,     \
-       __LINE__, current->pid, ##arg)
+#define mlx5_ib_err(_dev, format, arg...)                                      \
+       dev_err(&(_dev)->ib_dev.dev, "%s:%d:(pid %d): " format, __func__,      \
+               __LINE__, current->pid, ##arg)
 
-#define mlx5_ib_warn(dev, format, arg...)                              \
-pr_warn("%s:%s:%d:(pid %d): " format, (dev)->ib_dev.name, __func__,    \
-       __LINE__, current->pid, ##arg)
+#define mlx5_ib_warn(_dev, format, arg...)                                     \
+       dev_warn(&(_dev)->ib_dev.dev, "%s:%d:(pid %d): " format, __func__,     \
+                __LINE__, current->pid, ##arg)
 
 #define field_avail(type, fld, sz) (offsetof(type, fld) +              \
                                    sizeof(((type *)0)->fld) <= (sz))

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index a0cb260..3455b50 100644 (file)
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2826,8 +2826,9 @@ static int modify_raw_packet_qp_rq(
                                   MLX5_MODIFY_RQ_IN_MODIFY_BITMASK_RQ_COUNTER_SET_ID);
                        MLX5_SET(rqc, rqc, counter_set_id, raw_qp_param->rq_q_ctr_id);
                } else
-                       pr_info_once("%s: RAW PACKET QP counters are not supported on current FW\n",
-                                    dev->ib_dev.name);
+                       dev_info_once(
+                               &dev->ib_dev.dev,
+                               "RAW PACKET QP counters are not supported on current FW\n");
        }
 
        err = mlx5_core_modify_rq(dev->mdev, rq->base.mqp.qpn, in, inlen);
@@ -5798,8 +5799,9 @@ int mlx5_ib_modify_wq(struct ib_wq *wq, struct ib_wq_attr *wq_attr,
                        MLX5_SET(rqc, rqc, counter_set_id,
                                 dev->port->cnts.set_id);
                } else
-                       pr_info_once("%s: Receive WQ counters are not supported on current FW\n",
-                                    dev->ib_dev.name);
+                       dev_info_once(
+                               &dev->ib_dev.dev,
+                               "Receive WQ counters are not supported on current FW\n");
        }
 
        err = mlx5_core_modify_rq(dev->mdev, rwq->core_qp.qpn, in, inlen);

diff --git a/drivers/infiniband/hw/mthca/mthca_mad.c b/drivers/infiniband/hw/mthca/mthca_mad.c
index 093f775..2e5dc0a 100644 (file)
--- a/drivers/infiniband/hw/mthca/mthca_mad.c
+++ b/drivers/infiniband/hw/mthca/mthca_mad.c
@@ -58,8 +58,9 @@ static int mthca_update_rate(struct mthca_dev *dev, u8 port_num)
 
        ret = ib_query_port(&dev->ib_dev, port_num, tprops);
        if (ret) {
-               printk(KERN_WARNING "ib_query_port failed (%d) for %s port %d\n",
-                      ret, dev->ib_dev.name, port_num);
+               dev_warn(&dev->ib_dev.dev,
+                        "ib_query_port failed (%d) forport %d\n", ret,
+                        port_num);
                goto out;
        }
 

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index e578281..241a57a 100644 (file)
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -792,7 +792,7 @@ static void ocrdma_dispatch_ibevent(struct ocrdma_dev *dev,
                                                     qp->srq->ibsrq.
                                                     srq_context);
        } else if (dev_event) {
-               pr_err("%s: Fatal event received\n", dev->ibdev.name);
+               dev_err(&dev->ibdev.dev, "Fatal event received\n");
                ib_dispatch_event(&ib_evt);
        }
 

diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
index ed823cc..8e658ce 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -615,7 +615,7 @@ void rxe_port_up(struct rxe_dev *rxe)
        port->attr.phys_state = IB_PHYS_STATE_LINK_UP;
 
        rxe_port_event(rxe, IB_EVENT_PORT_ACTIVE);
-       pr_info("set %s active\n", rxe->ib_dev.name);
+       dev_info(&rxe->ib_dev.dev, "set active\n");
 }
 
 /* Caller must hold net_info_lock */
@@ -628,7 +628,7 @@ void rxe_port_down(struct rxe_dev *rxe)
        port->attr.phys_state = IB_PHYS_STATE_LINK_DOWN;
 
        rxe_port_event(rxe, IB_EVENT_PORT_ERR);
-       pr_info("set %s down\n", rxe->ib_dev.name);
+       dev_info(&rxe->ib_dev.dev, "set down\n");
 }
 
 static int rxe_notify(struct notifier_block *not_blk,

diff --git a/drivers/infiniband/sw/rxe/rxe_sysfs.c b/drivers/infiniband/sw/rxe/rxe_sysfs.c
index d5ed757..73a19f8 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_sysfs.c
+++ b/drivers/infiniband/sw/rxe/rxe_sysfs.c
@@ -105,7 +105,7 @@ static int rxe_param_set_add(const char *val, const struct kernel_param *kp)
        }
 
        rxe_set_port_state(ndev);
-       pr_info("added %s to %s\n", rxe->ib_dev.name, intf);
+       dev_info(&rxe->ib_dev.dev, "added %s\n", intf);
 err:
        if (ndev)
                dev_put(ndev);