scsi: qla2xxx: Simplify if condition evaluation
authorDeepak R Varma <drv@mailo.com>
Thu, 12 Jan 2023 06:26:46 +0000 (11:56 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 24 Jan 2023 02:18:16 +0000 (21:18 -0500)
A logical evaluation of type (!A || A && B) can be simplified as (!A || B).
Improvement by suggested by excluded_middle.cocci Coccinelel semantic
patch.

Link: https://lore.kernel.org/r/Y7+oJuah0MgEW0PQ@ubun2204.myguest.virtualbox.org
Signed-off-by: Deepak R Varma <drv@mailo.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.c

index dbd6660..aa0cf5c 100644 (file)
@@ -1012,8 +1012,7 @@ void qlt_free_session_done(struct work_struct *work)
                }
 
                if (ha->flags.edif_enabled &&
-                   (!own || (own &&
-                             own->iocb.u.isp24.status_subcode == ELS_PLOGI))) {
+                               (!own || own->iocb.u.isp24.status_subcode == ELS_PLOGI)) {
                        sess->edif.authok = 0;
                        if (!ha->flags.host_shutting_down) {
                                ql_dbg(ql_dbg_edif, vha, 0x911e,