gpio: dwapb: Drop redundant check in dwapb_irq_set_type()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 1 Jun 2021 16:21:27 +0000 (19:21 +0300)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Wed, 2 Jun 2021 13:34:21 +0000 (15:34 +0200)
For more than 15 years we may not get into ->irq_set_type()
without any meaningful type provided.

Drop redundant check in dwapb_irq_set_type().

See the commit e76de9f8eb67 ("[PATCH] genirq: add SA_TRIGGER support")
out of curiosity.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-dwapb.c

index d3233cc..939701c 100644 (file)
@@ -297,9 +297,6 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
        irq_hw_number_t bit = irqd_to_hwirq(d);
        unsigned long level, polarity, flags;
 
-       if (type & ~IRQ_TYPE_SENSE_MASK)
-               return -EINVAL;
-
        spin_lock_irqsave(&gc->bgpio_lock, flags);
        level = dwapb_read(gpio, GPIO_INTTYPE_LEVEL);
        polarity = dwapb_read(gpio, GPIO_INT_POLARITY);