vfio/pds: Add missing PCI_IOV depends
authorShixiong Ou <oushixiong@kylinos.cn>
Wed, 6 Sep 2023 01:49:42 +0000 (09:49 +0800)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 18 Sep 2023 19:36:52 +0000 (13:36 -0600)
If PCI_ATS isn't set, then pdev->physfn is not defined.
it causes a compilation issue:

../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
  165 |   __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
      |                              ^~~~~~

So adding PCI_IOV depends to select PCI_ATS.

Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20230906014942.1658769-1-oushixiong@kylinos.cn
Fixes: 63f77a7161a2 ("vfio/pds: register with the pds_core PF")
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/pds/Kconfig

index 407b3fd..6eceef7 100644 (file)
@@ -3,7 +3,7 @@
 
 config PDS_VFIO_PCI
        tristate "VFIO support for PDS PCI devices"
-       depends on PDS_CORE
+       depends on PDS_CORE && PCI_IOV
        select VFIO_PCI_CORE
        help
          This provides generic PCI support for PDS devices using the VFIO