Fix performance issue in UpdateManager::AddNode()

As node pointes are allocated by FixedMeomrySizedPool and the pool
allocates pages and page can be allocated at any location by global new.
it won't help with cache locality by keeping nodes in sorted order by address.

creating 100,000 actor takes 3 Second and 200,000 actor takes 11 Second .

Change-Id: Ic3b0da35ebd98d994d876083ffe3ee44f082d8c0

diff --git a/dali/internal/update/manager/update-manager.cpp b/dali/internal/update/manager/update-manager.cpp
index f60bbdf..4cb0dec 100644 (file)
--- a/dali/internal/update/manager/update-manager.cpp
+++ b/dali/internal/update/manager/update-manager.cpp
@@ -378,20 +378,11 @@ void UpdateManager::AddNode( OwnerPointer<Node>& node )
 {
   DALI_ASSERT_ALWAYS( nullptr == node->GetParent() ); // Should not have a parent yet
 
-  // Nodes must be sorted by pointer
   Node* rawNode = node.Release();
   DALI_LOG_INFO( gLogFilter, Debug::General, "[%x] AddNode\n", rawNode );
 
-  Vector<Node*>::Iterator begin = mImpl->nodes.Begin();
-  for( Vector<Node*>::Iterator iter = mImpl->nodes.End()-1; iter >= begin; --iter )
-  {
-    if( rawNode > (*iter) )
-    {
-      mImpl->nodes.Insert((iter+1), rawNode );
-      rawNode->CreateTransform( &mImpl->transformManager );
-      return;
-    }
-  }
+  mImpl->nodes.PushBack(rawNode);
+  rawNode->CreateTransform(&mImpl->transformManager);
 }
 
 void UpdateManager::ConnectNode( Node* parent, Node* node )