Revert "wifi: mac80211: Update skb's control block key in ieee80211_tx_dequeue()"

[ Upstream commit 0937cb5f345c79d702b4d0d744e2a2529b551cb2 ]

This reverts commit a104042e2bf6528199adb6ca901efe7b60c2c27f.

Since the original bug seems to have been around for years,
but a new issue was report with the fix, revert the fix for
now. We have a couple of weeks to figure it out for this
release, if needed.

Reported-by: Bert Karwatzki <spasswolf@web.de>
Closes: https://lore.kernel.org/linux-wireless/20250410215527.3001-1-spasswolf@web.de
Fixes: a104042e2bf6 ("wifi: mac80211: Update skb's control block key in ieee80211_tx_dequeue()")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 9b3a5ef20f29eebe864f6904423eb740c10b59c0..0ff8b56f58070849c87e22ee0f900f5cf59a1d74 100644 (file)
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -3892,7 +3892,6 @@ begin:
         * The key can be removed while the packet was queued, so need to call
         * this here to get the current key.
         */
-       info->control.hw_key = NULL;
        r = ieee80211_tx_h_select_key(&tx);
        if (r != TX_CONTINUE) {
                ieee80211_free_txskb(&local->hw, skb);