ASoC: rt1011: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:06 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:09:55 +0000 (13:09 +0000)
cppcheck warning:

sound/soc/codecs/rt1011.c:1781:63: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]

  (pll_code.m_bp ? 0 : pll_code.m_code) << RT1011_PLL1_QM_SFT |
                                                              ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1011.c

index 39a9f17..238cb66 100644 (file)
@@ -1778,8 +1778,9 @@ static int rt1011_set_component_pll(struct snd_soc_component *component,
                pll_code.n_code, pll_code.k_code);
 
        snd_soc_component_write(component, RT1011_PLL_1,
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT1011_PLL1_QM_SFT |
-               pll_code.m_bp << RT1011_PLL1_BPM_SFT | pll_code.n_code);
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT1011_PLL1_QM_SFT) |
+               (pll_code.m_bp << RT1011_PLL1_BPM_SFT) |
+               pll_code.n_code);
        snd_soc_component_write(component, RT1011_PLL_2,
                pll_code.k_code);