Provide a meaningful diagnostic when LLVM_PATH doesn't point to a directory
authorLouis Dionne <ldionne@apple.com>
Mon, 19 Aug 2019 23:51:26 +0000 (23:51 +0000)
committerLouis Dionne <ldionne@apple.com>
Mon, 19 Aug 2019 23:51:26 +0000 (23:51 +0000)
llvm-svn: 369312

libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake
libcxxabi/cmake/Modules/HandleOutOfTreeLLVM.cmake

index 11c1331..5746afb 100644 (file)
@@ -9,6 +9,9 @@ macro(find_llvm_parts)
     set(LLVM_PATH ${LLVM_PATH} CACHE PATH "Path to LLVM source tree")
     set(LLVM_MAIN_SRC_DIR ${LLVM_PATH})
     set(LLVM_CMAKE_PATH "${LLVM_PATH}/cmake/modules")
+    if (NOT IS_DIRECTORY "${LLVM_PATH}")
+      message(FATAL_ERROR "The provided LLVM_PATH (${LLVM_PATH}) is not a valid directory")
+    endif()
   elseif(LLVM_CONFIG_PATH)
     message(STATUS "Found LLVM_CONFIG_PATH as ${LLVM_CONFIG_PATH}")
     set(LIBCXX_USING_INSTALLED_LLVM 1)
index 4420aca..c43308e 100644 (file)
@@ -9,6 +9,9 @@ macro(find_llvm_parts)
     set(LLVM_PATH ${LLVM_PATH} CACHE PATH "Path to LLVM source tree")
     set(LLVM_MAIN_SRC_DIR ${LLVM_PATH})
     set(LLVM_CMAKE_PATH "${LLVM_PATH}/cmake/modules")
+    if (NOT IS_DIRECTORY "${LLVM_PATH}")
+      message(FATAL_ERROR "The provided LLVM_PATH (${LLVM_PATH}) is not a valid directory")
+    endif()
   elseif(LLVM_CONFIG_PATH)
     message(STATUS "Found LLVM_CONFIG_PATH as ${LLVM_CONFIG_PATH}")
     set(LIBCXXABI_USING_INSTALLED_LLVM 1)