Remove GetThreadSuffixSupported from GDBRemoteCommunication **base** class

Despite its comment, the function is only used in the Client class, and its presence was merely
complicating mock implementation in unit tests.

llvm-svn: 278785

diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
index 623f0d166532e5769e1b82c5706aabefed829ac3..5eb1f290168988c751a7852fc28d8ebb563d2dfc 100644 (file)
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
@@ -125,12 +125,6 @@ public:
         return m_send_acks;
     }
 
-    //------------------------------------------------------------------
-    // Client and server must implement these pure virtual functions
-    //------------------------------------------------------------------
-    virtual bool
-    GetThreadSuffixSupported () = 0;
-
     //------------------------------------------------------------------
     // Set the global packet timeout.
     //

diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
index 424a949a9abb879072db5fb39d93bf461ae896e1..83502f4727e6c1a7adf5183e7d23224eeca5f0cc 100644 (file)
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
@@ -65,7 +65,7 @@ public:
                                         std::string &response_string);
 
     bool
-    GetThreadSuffixSupported () override;
+    GetThreadSuffixSupported();
 
     // This packet is usually sent first and the boolean return value
     // indicates if the packet was send and any response was received

diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
index d2fd70042ccc95a6b27d1239e326fc4f9d99dac2..7bb67263f3b85f5ee82826fb0594720b7619cf06 100644 (file)
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
@@ -176,12 +176,6 @@ protected:
                               });
     }
 
-    bool
-    GetThreadSuffixSupported () override
-    {
-        return true;
-    }
-
     //------------------------------------------------------------------
     /// Launch a process with the current launch settings.
     ///

diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
index be67114b3325a81363f74fd7a8def7690aaea113..596391c5c0113dcc70619105f85946999cede0a3 100644 (file)
--- a/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
+++ b/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
@@ -60,12 +60,6 @@ struct MockServer : public GDBRemoteCommunicationServer
 {
     MockServer() : GDBRemoteCommunicationServer("mock-server", "mock-server.listener") { m_send_acks = false; }
 
-    bool
-    GetThreadSuffixSupported() override
-    {
-        return false;
-    }
-
     PacketResult
     SendPacket(llvm::StringRef payload)
     {
@@ -84,12 +78,6 @@ struct MockServer : public GDBRemoteCommunicationServer
 struct TestClient : public GDBRemoteClientBase
 {
     TestClient() : GDBRemoteClientBase("test.client", "test.client.listener") { m_send_acks = false; }
-
-    bool
-    GetThreadSuffixSupported() override
-    {
-        return false;
-    }
 };
 
 struct ContinueFixture