Fix static analysis issues

Change-Id: I530f2a66559bf085d2cfb4a2c1f5069c9042dcee
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

diff --git a/src/manifest_parser/manifest_parser.cc b/src/manifest_parser/manifest_parser.cc
index 97d76f5f5f204ad779a7dfe01e6784a28eb0ca64..f0c26884d5bfd9586675546e830589cf6afe0db6 100644 (file)
--- a/src/manifest_parser/manifest_parser.cc
+++ b/src/manifest_parser/manifest_parser.cc
@@ -31,7 +31,7 @@ const std::string& ManifestParser::GetErrorMessage() const {
 
 bool ManifestParser::ParseManifest(const std::filesystem::path& path,
     std::shared_ptr<ManifestConstraints> constraints) {
-  return impl_->ParseManifest(path, constraints);
+  return impl_->ParseManifest(path, std::move(constraints));
 }
 
 std::shared_ptr<const ManifestData> ManifestParser::GetManifestData(

diff --git a/src/manifest_parser/manifest_parser_impl.cc b/src/manifest_parser/manifest_parser_impl.cc
index 8725659a3d69baeb4fa1f8145f7382a0b0c43a09..d69dbdda6cc9640b80ed1195539342b96ffa53d1 100644 (file)
--- a/src/manifest_parser/manifest_parser_impl.cc
+++ b/src/manifest_parser/manifest_parser_impl.cc
@@ -58,8 +58,8 @@ bool ManifestParserImpl::ParseManifest(const fs::path& manifest_path,
     return false;
   }
 
-  manifest_ =
-      parser::LoadManifest(manifest_path.string(), &error_, constraints);
+  manifest_ = parser::LoadManifest(manifest_path.string(), &error_,
+      std::move(constraints));
   if (!manifest_.get())
     return false;
   if (!ParseManifestData(&error_))

diff --git a/src/manifest_parser/utils/string_util.cc b/src/manifest_parser/utils/string_util.cc
index 502cc060bfb6e601cb54224e89f8a2e893259c94..fb26e6056b9d34c598c1c0670c2072cbdeb93631 100644 (file)
--- a/src/manifest_parser/utils/string_util.cc
+++ b/src/manifest_parser/utils/string_util.cc
@@ -213,7 +213,7 @@ std::string DecodePercentEscapedCharacter(const std::string& text) {
   return std::string(output.begin(), output.end());
 }
 
-std::string Join(const std::vector<std::string> strings, const char* delim) {
+std::string Join(const std::vector<std::string>& strings, const char* delim) {
   std::ostringstream oss;
   std::copy(strings.begin(), strings.end(),
       std::ostream_iterator<std::string>(oss, delim));

diff --git a/src/manifest_parser/utils/string_util.h b/src/manifest_parser/utils/string_util.h
index 6b4df365a4c5bc6695f8171d9cfa9ba6b73d64d6..6b62e4ffcaebbf33cb89a50f0c3a44543174eace 100644 (file)
--- a/src/manifest_parser/utils/string_util.h
+++ b/src/manifest_parser/utils/string_util.h
@@ -95,7 +95,7 @@ std::string DecodePercentEscapedCharacter(const std::string& text);
  * @param delim  delimiter between strings
  * @return concatenated string
  */
-std::string Join(const std::vector<std::string> strings, const char* delim);
+std::string Join(const std::vector<std::string>& strings, const char* delim);
 
 /**
  * @brief Trim