Use "Atom-Shell" instead of "atom-shell" for product names.
authorCheng Zhao <zcbenz@gmail.com>
Sun, 24 Nov 2013 15:17:48 +0000 (23:17 +0800)
committerCheng Zhao <zcbenz@gmail.com>
Sun, 24 Nov 2013 15:17:48 +0000 (23:17 +0800)
atom.gyp
common/crash_reporter/crash_reporter_mac.mm
common/crash_reporter/crash_reporter_win.cc
spec/fixtures/api/crash.html

index 4bb0dfc..d0aaefa 100644 (file)
--- a/atom.gyp
+++ b/atom.gyp
                 'tools/mac/generate_breakpad_symbols.py',
                 '--build-dir=<(PRODUCT_DIR)',
                 '--binary=<(PRODUCT_DIR)/<(product_name).app/Contents/MacOS/<(product_name)',
-                '--symbols-dir=<(PRODUCT_DIR)/atom-shell.breakpad.syms',
+                '--symbols-dir=<(PRODUCT_DIR)/Atom-Shell.breakpad.syms',
                 '--clear',
                 '--jobs=16',
               ],
index f3ab45d..dac77e7 100644 (file)
@@ -31,7 +31,7 @@ void CrashReporterMac::InitBreakpad(const std::string& product_name,
   NSMutableDictionary* parameters =
       [NSMutableDictionary dictionaryWithCapacity:4];
 
-  [parameters setValue:@"atom-shell"
+  [parameters setValue:@"Atom-Shell"
                 forKey:@BREAKPAD_PRODUCT];
   [parameters setValue:base::SysUTF8ToNSString(product_name)
                 forKey:@BREAKPAD_PRODUCT_DISPLAY];
index 39837ec..e62986b 100644 (file)
@@ -100,7 +100,7 @@ google_breakpad::CustomClientInfo* CrashReporterWin::GetCustomInfo(
   custom_info_entries_.reserve(2 + upload_parameters_.size());
 
   custom_info_entries_.push_back(google_breakpad::CustomInfoEntry(
-      L"prod", UTF8ToWide(product_name).c_str()));
+      L"prod", L"Atom-Shell"));
   custom_info_entries_.push_back(google_breakpad::CustomInfoEntry(
       L"ver", UTF8ToWide(version).c_str()));
 
index 8933288..b0c3664 100644 (file)
@@ -3,6 +3,7 @@
 <script type="text/javascript" charset="utf-8">
 var crashReporter = require('crash-reporter');
 crashReporter.start({
+  productName: 'Something other than Atom-Shell',
   submitUrl: 'http://127.0.0.1:1127',
   autoSubmit: true,
   ignoreSystemCrashHandler: true,