projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5f69c65
)
ALSA: seq: remove redundant unsigned comparison to zero
author
Wang Weiyang
<wangweiyang2@huawei.com>
Fri, 21 Jul 2023 10:31:24 +0000
(18:31 +0800)
committer
Takashi Iwai
<tiwai@suse.de>
Fri, 21 Jul 2023 11:02:16 +0000
(13:02 +0200)
Since struct snd_ump_block_info::first_group is unsigned char, comparison
to zero is redundant
Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com>
Fixes: 81fd444aa371 ("ALSA: seq: Bind UMP device")
Link:
https://lore.kernel.org/r/20230721103124.18522-1-wangweiyang2@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_ump_client.c
patch
|
blob
|
history
diff --git
a/sound/core/seq/seq_ump_client.c
b/sound/core/seq/seq_ump_client.c
index fe21c801af742068ca134119aa350f8b8a29752f..f26a1812dfa73e564aaf77f8197045c8e9a3a933 100644
(file)
--- a/
sound/core/seq/seq_ump_client.c
+++ b/
sound/core/seq/seq_ump_client.c
@@
-298,8
+298,7
@@
static void update_group_attrs(struct seq_ump_client *client)
}
list_for_each_entry(fb, &client->ump->block_list, list) {
- if (fb->info.first_group < 0 ||
- fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS)
+ if (fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS)
break;
group = &client->groups[fb->info.first_group];
for (i = 0; i < fb->info.num_groups; i++, group++) {