[clangd] Move IncludeCleaner tracer to the actual computation
authorKirill Bobyrev <kbobyrev@google.com>
Thu, 25 Nov 2021 12:19:01 +0000 (13:19 +0100)
committerKirill Bobyrev <kbobyrev@google.com>
Thu, 25 Nov 2021 12:19:01 +0000 (13:19 +0100)
This way we won't get results with 0 ms for all the users with disabled
IncludeCleaner.

clang-tools-extra/clangd/IncludeCleaner.cpp

index b9267ff..a0b9e30 100644 (file)
@@ -317,12 +317,12 @@ std::vector<const Inclusion *> computeUnusedIncludes(ParsedAST &AST) {
 
 std::vector<Diag> issueUnusedIncludesDiagnostics(ParsedAST &AST,
                                                  llvm::StringRef Code) {
-  trace::Span Tracer("IncludeCleaner::issueUnusedIncludesDiagnostics");
   const Config &Cfg = Config::current();
   if (Cfg.Diagnostics.UnusedIncludes != Config::UnusedIncludesPolicy::Strict ||
       Cfg.Diagnostics.SuppressAll ||
       Cfg.Diagnostics.Suppress.contains("unused-includes"))
     return {};
+  trace::Span Tracer("IncludeCleaner::issueUnusedIncludesDiagnostics");
   std::vector<Diag> Result;
   std::string FileName =
       AST.getSourceManager()