projects
/
platform
/
kernel
/
linux-rpi3.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d758619
)
gpu: host1x: Fix error handling
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Mon, 10 Apr 2017 20:29:22 +0000
(22:29 +0200)
committer
Thierry Reding
<treding@nvidia.com>
Thu, 15 Jun 2017 12:06:49 +0000
(14:06 +0200)
If 'devm_reset_control_get' returns an error, then we erroneously return
success because error code is taken from 'host->clk' instead of
'host->rst'.
Fixes:
b386c6b73ac6
("gpu: host1x: Support module reset")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link:
http://patchwork.freedesktop.org/patch/msgid/20170410202922.17665-1-christophe.jaillet@wanadoo.fr
drivers/gpu/host1x/dev.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/host1x/dev.c
b/drivers/gpu/host1x/dev.c
index
f05ebb1
..
ac65f52
100644
(file)
--- a/
drivers/gpu/host1x/dev.c
+++ b/
drivers/gpu/host1x/dev.c
@@
-172,7
+172,7
@@
static int host1x_probe(struct platform_device *pdev)
host->rst = devm_reset_control_get(&pdev->dev, "host1x");
if (IS_ERR(host->rst)) {
- err = PTR_ERR(host->
clk
);
+ err = PTR_ERR(host->
rst
);
dev_err(&pdev->dev, "failed to get reset: %d\n", err);
return err;
}