ksmbd: fix passing freed memory 'aux_payload_buf'
authorNamjae Jeon <linkinjeon@kernel.org>
Tue, 12 Sep 2023 14:29:10 +0000 (23:29 +0900)
committerSteve French <stfrench@microsoft.com>
Wed, 13 Sep 2023 15:21:05 +0000 (10:21 -0500)
The patch e2b76ab8b5c9: "ksmbd: add support for read compound" leads
to the following Smatch static checker warning:

  fs/smb/server/smb2pdu.c:6329 smb2_read()
        warn: passing freed memory 'aux_payload_buf'

It doesn't matter that we're passing a freed variable because nbytes is
zero. This patch set "aux_payload_buf = NULL" to make smatch silence.

Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb2pdu.c

index 749660110878fdbd75c2820a14eaf7ba543496ce..544022dd6d2007132a1bc3a310d4ee57f671a047 100644 (file)
@@ -6312,7 +6312,7 @@ int smb2_read(struct ksmbd_work *work)
                                                      aux_payload_buf,
                                                      nbytes);
                kvfree(aux_payload_buf);
-
+               aux_payload_buf = NULL;
                nbytes = 0;
                if (remain_bytes < 0) {
                        err = (int)remain_bytes;