media: imx: imx8mq-mipi-csi2: remove wrong irq config write operation
authorMartin Kepplinger <martin.kepplinger@puri.sm>
Thu, 16 Dec 2021 09:03:35 +0000 (10:03 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 23 Jan 2022 20:18:42 +0000 (21:18 +0100)
The place where this register writel() that masks one interrupt is placed
does not guarantee that the device is powered so that's not allowed.
Moreover imx8mq_mipi_csi_start_stream() masks the interrupt anyway so the
write is not even needed. Remove it as this is a mistake that slipped in
with the driver.

Fixes: f33fd8d77dd0 ("media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller")
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/imx/imx8mq-mipi-csi2.c

index 7adbdd1..8f3cc13 100644 (file)
@@ -398,9 +398,6 @@ static int imx8mq_mipi_csi_s_stream(struct v4l2_subdev *sd, int enable)
        struct csi_state *state = mipi_sd_to_csi2_state(sd);
        int ret = 0;
 
-       imx8mq_mipi_csi_write(state, CSI2RX_IRQ_MASK,
-                             CSI2RX_IRQ_MASK_ULPS_STATUS_CHANGE);
-
        if (enable) {
                ret = pm_runtime_resume_and_get(state->dev);
                if (ret < 0)