Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb
authorIker Pedrosa <ikerpedrosam@gmail.com>
Thu, 8 Aug 2013 10:56:44 +0000 (12:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Aug 2013 22:20:25 +0000 (15:20 -0700)
Checking the return of dev_alloc_skb as stated in the following bug:
https://bugzilla.kernel.org/show_bug.cgi?id=60401

Reported-by: RUC_Soft_Sec rucsoftsec@gmail.com
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_rx.c

index e75364e..6a51f29 100644 (file)
@@ -777,6 +777,8 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 
                /* Allocate new skb for releasing to upper layer */
                sub_skb = dev_alloc_skb(RTLLIB_SKBBUFFER_SIZE);
+               if (!sub_skb)
+                       return 0;
                skb_reserve(sub_skb, 12);
                data_ptr = (u8 *)skb_put(sub_skb, skb->len);
                memcpy(data_ptr, skb->data, skb->len);
@@ -825,6 +827,8 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 
                        /* Allocate new skb for releasing to upper layer */
                        sub_skb = dev_alloc_skb(nSubframe_Length + 12);
+                       if (!sub_skb)
+                               return 0;
                        skb_reserve(sub_skb, 12);
                        data_ptr = (u8 *)skb_put(sub_skb, nSubframe_Length);
                        memcpy(data_ptr, skb->data, nSubframe_Length);