Review feedback changes
authorBrian Sullivan <briansul@microsoft.com>
Mon, 16 Oct 2017 22:16:31 +0000 (15:16 -0700)
committerBrian Sullivan <briansul@microsoft.com>
Mon, 16 Oct 2017 22:16:31 +0000 (15:16 -0700)
src/jit/gentree.h

index bb5f84183c4b70ad6c4ca7151717fbc021391f56..c1800229cb7922f4ed92698716dfeb8579245314 100644 (file)
@@ -2530,26 +2530,25 @@ struct GenTreeIntConCommon : public GenTree
     {
     }
 
-    bool FitsInI8()
+    bool FitsInI8() // IconValue() fits into 8-bit signed storage
     {
         return FitsInI8(IconValue());
     }
 
-    static bool FitsInI8(ssize_t val)
+    static bool FitsInI8(ssize_t val) // Constant fits into 8-bit signed storage
     {
-
-        return (char)val == val;
+        return (int8_t)val == val;
     }
 
-    bool FitsInI32()
+    bool FitsInI32() // IconValue() fits into 32-bit signed storage
     {
         return FitsInI32(IconValue());
     }
 
-    static bool FitsInI32(ssize_t val)
+    static bool FitsInI32(ssize_t val) // Constant fits into 32-bit signed storage
     {
 #ifdef _TARGET_64BIT_
-        return (int)val == val;
+        return (int32_t)val == val;
 #else
         return true;
 #endif