pinctrl: qcom: Print high/low status of gpios in debugfs

I was debugging some gpio issues and I thought that the output of gpio
debugfs was telling me the high or low level of the gpios with a '1' or
a '0'. We saw a line like this though:

 gpio93  : in 4 2mA pull down

and I started to think that there may be a gas leak in the building
because '4' doesn't mean high or low, and other pins said '0' or '1'. It
turns out, '4' is the function selection for the pinmux of the gpio and
not the value on the pin. Reading code helps decipher what debugfs is
actually saying.

Add support to read the input or output pin depending on how the pin is
configured so we can easily see the high or low value of the pin in
debugfs. Now the output looks like

 gpio93  : in   low  func4 2mA pull down

which clearly shows that the pin is an input, low, with function 4 and a
2mA drive strength plus a pull down.

Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Alexandru M Stan <amstan@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index c3c77b8..d6b10bc 100644 (file)
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -502,7 +502,8 @@ static void msm_gpio_dbg_show_one(struct seq_file *s,
        int is_out;
        int drive;
        int pull;
-       u32 ctl_reg;
+       int val;
+       u32 ctl_reg, io_reg;
 
        static const char * const pulls_keeper[] = {
                "no pull",
@@ -522,13 +523,20 @@ static void msm_gpio_dbg_show_one(struct seq_file *s,
 
        g = &pctrl->soc->groups[offset];
        ctl_reg = readl(pctrl->regs + g->ctl_reg);
+       io_reg = readl(pctrl->regs + g->io_reg);
 
        is_out = !!(ctl_reg & BIT(g->oe_bit));
        func = (ctl_reg >> g->mux_bit) & 7;
        drive = (ctl_reg >> g->drv_bit) & 7;
        pull = (ctl_reg >> g->pull_bit) & 3;
 
-       seq_printf(s, " %-8s: %-3s %d", g->name, is_out ? "out" : "in", func);
+       if (is_out)
+               val = !!(io_reg & BIT(g->out_bit));
+       else
+               val = !!(io_reg & BIT(g->in_bit));
+
+       seq_printf(s, " %-8s: %-3s", g->name, is_out ? "out" : "in");
+       seq_printf(s, " %-4s func%d", val ? "high" : "low", func);
        seq_printf(s, " %dmA", msm_regval_to_drive(drive));
        if (pctrl->soc->pull_no_keeper)
                seq_printf(s, " %s", pulls_no_keeper[pull]);