reset: ti_syscon: fix a ti_syscon_reset_status issue
authorJiancheng Xue <xuejiancheng@hisilicon.com>
Wed, 30 Nov 2016 01:03:32 +0000 (09:03 +0800)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Mon, 9 Jan 2017 09:38:58 +0000 (10:38 +0100)
If STATUS_SET was not set, ti_syscon_reset_status would always return 0
no matter whether the status_bit was set or not.

Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
Fixes: cc7c2bb1493c ("reset: add TI SYSCON based reset driver")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/reset-ti-syscon.c

index 47f0ffd..1799fd4 100644 (file)
@@ -154,8 +154,8 @@ static int ti_syscon_reset_status(struct reset_controller_dev *rcdev,
        if (ret)
                return ret;
 
-       return (reset_state & BIT(control->status_bit)) &&
-                       (control->flags & STATUS_SET);
+       return !(reset_state & BIT(control->status_bit)) ==
+               !(control->flags & STATUS_SET);
 }
 
 static struct reset_control_ops ti_syscon_reset_ops = {