element: Add guard to gst_element_release_pad() to ensure the pad belongs to this...

It's a programming error to pass other pads here, and it easily causes
crashes or other problematic behaviour down the road as subclasses
usually assume to only get their pads.

diff --git a/gst/gstelement.c b/gst/gstelement.c
index 4ff9c67..a7aa591 100644 (file)
--- a/gst/gstelement.c
+++ b/gst/gstelement.c
@@ -345,6 +345,7 @@ gst_element_release_request_pad (GstElement * element, GstPad * pad)
   g_return_if_fail (GST_PAD_PAD_TEMPLATE (pad) == NULL ||
       GST_PAD_TEMPLATE_PRESENCE (GST_PAD_PAD_TEMPLATE (pad)) ==
       GST_PAD_REQUEST);
+  g_return_if_fail (GST_PAD_PARENT (pad) == element);
 
   oclass = GST_ELEMENT_GET_CLASS (element);