projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
833a94a
)
ASoC: qdsp6: Fix an IS_ERR() vs NULL bug
author
Miaoqian Lin
<linmq006@gmail.com>
Sat, 11 Dec 2021 06:58:29 +0000
(06:58 +0000)
committer
Mark Brown
<broonie@kernel.org>
Tue, 14 Dec 2021 17:15:52 +0000
(17:15 +0000)
The function gpr_alloc_port return ERR_PTR on errors, it doesn't return
null.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link:
https://lore.kernel.org/r/20211211065840.1221-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6apm.c
patch
|
blob
|
history
diff --git
a/sound/soc/qcom/qdsp6/q6apm.c
b/sound/soc/qcom/qdsp6/q6apm.c
index
13598ef
..
3e007d6
100644
(file)
--- a/
sound/soc/qcom/qdsp6/q6apm.c
+++ b/
sound/soc/qcom/qdsp6/q6apm.c
@@
-630,9
+630,9
@@
struct q6apm_graph *q6apm_graph_open(struct device *dev, q6apm_cb cb,
init_waitqueue_head(&graph->cmd_wait);
graph->port = gpr_alloc_port(apm->gdev, dev, graph_callback, graph);
- if (
!graph->port
) {
+ if (
IS_ERR(graph->port)
) {
kfree(graph);
- ret =
-ENOMEM
;
+ ret =
PTR_ERR(graph->port)
;
goto err;
}