gdb

	PR mi/2549:
	* mi/mi-main.c (get_register): Use get_formatted_print_options.

gdb/testsuite

2008-11-14  Nick Roberts  <nickrob@snap.net.nz>

	* gdb.mi/gdb2549.exp: New file.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5b35e05..6c5ddf2 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2008-11-14  Tom Tromey  <tromey@redhat.com>
+
+       PR mi/2549:
+       * mi/mi-main.c (get_register): Use get_formatted_print_options.
+
 2008-11-13  Joel Brobecker  <brobecker@adacore.com>
 
        * printcmd.c: define PRINTF_HAS_LONG_LONG only if not yet defined.

diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index a9fbcad..4554008 100644 (file)
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -501,7 +501,7 @@ get_register (int regnum, int format)
   else
     {
       struct value_print_options opts;
-      get_user_print_options (&opts);
+      get_formatted_print_options (&opts, format);
       opts.deref_ref = 1;
       val_print (register_type (current_gdbarch, regnum), buffer, 0, 0,
                 stb->stream, 0, &opts, current_language);

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 0da2e5f..2845351 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2008-11-14  Nick Roberts  <nickrob@snap.net.nz>
+
+       * gdb.mi/gdb2549.exp: New file.
+
 2008-11-11  Doug Evans  <dje@google.com>
 
        * gdb.base/callexit.exp: New file.

diff --git a/gdb/testsuite/gdb.mi/gdb2549.exp b/gdb/testsuite/gdb.mi/gdb2549.exp
new file mode 100644 (file)
index 0000000..bba7964
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/gdb2549.exp
@@ -0,0 +1,85 @@
+# Copyright 2008 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test essential Machine interface (MI) operations
+#
+# Verify that, using the MI, we can run a simple program and look at registers.
+#
+# The goal is not to test gdb functionality, which is done by other tests,
+# but to verify the correct output response to MI operations.
+#
+
+
+load_lib mi-support.exp
+set MIFLAGS "-i=mi"
+
+gdb_exit
+if [mi_gdb_start] {
+    continue
+}
+
+set testfile "basics"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
+     untested mi-regs.exp
+     return -1
+}
+
+proc register_tests_no_exec { } {
+       # Test the generic IDT chip.
+       mi_gdb_test "111-data-list-register-values" \
+               ".*111\\^error,msg=\"mi_cmd_data_list_register_values: Usage: -data-list-register-values <format> \\\[<regnum1>...<regnumN>\\\]\"" \
+               "wrong arguments"
+
+       mi_gdb_test "111-data-list-register-values x" \
+               ".*111\\^error,msg=\"No registers\.\"" \
+               "no executable"
+}
+
+proc register_tests { } {
+    global hex
+    global decimal
+    set octal "\[0-7\]+"
+    set binary "\[0-1\]+"
+    set float "\\-?((\[0-9\]+(\\.\[0-9\]+)?(e\[-+\]\[0-9\]+)?)|(nan\\($hex\\)))"
+
+    mi_gdb_test "222-data-list-register-values x" \
+           "222\\^done,register-values=\\\[\{number=\"0\",value=\"$hex\"\}.*\\\]" \
+           "register values x"
+
+    mi_gdb_test "333-data-list-register-values f" \
+           "333\\^done,register-values=\\\[\{number=\"0\",value=\"$float\"\}.*\\\]" \
+           "register values f"
+
+    mi_gdb_test "444-data-list-register-values d" \
+           "444\\^done,register-values=\\\[\{number=\"0\",value=\"-?$decimal\"\}.*\\\]" \
+           "register values d"
+
+    mi_gdb_test "555-data-list-register-values o" \
+           "555\\^done,register-values=\\\[\{number=\"0\",value=\"$octal\"\}.*\\\]" \
+           "register values o"
+
+    mi_gdb_test "666-data-list-register-values t" \
+           "666\\^done,register-values=\\\[\{number=\"0\",value=\"$binary\"\}.*\\\]" \
+           "register values t"
+}
+
+register_tests_no_exec
+mi_run_to_main
+register_tests
+
+mi_gdb_exit
+return 0