drm/amdkfd: Return true/false (not 1/0) from bool functions
authorYang Li <yang.lee@linux.alibaba.com>
Thu, 5 May 2022 23:23:11 +0000 (07:23 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 May 2022 20:58:05 +0000 (16:58 -0400)
Return boolean values ("true" or "false") instead of 1 or 0 from bool
functions. This fixes the following warnings from coccicheck:

./drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c:244:9-10: WARNING:
return of 0/1 in function 'event_interrupt_isr_v11' with return type
bool

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c

index c3919aa..1431f09 100644 (file)
@@ -241,14 +241,14 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
        if (/*!KFD_IRQ_IS_FENCE(client_id, source_id) &&*/
            (vmid < dev->vm_info.first_vmid_kfd ||
            vmid > dev->vm_info.last_vmid_kfd))
-               return 0;
+               return false;
 
        pasid = SOC15_PASID_FROM_IH_ENTRY(ih_ring_entry);
        context_id0 = SOC15_CONTEXT_ID0_FROM_IH_ENTRY(ih_ring_entry);
 
        if ((source_id == SOC15_INTSRC_CP_END_OF_PIPE) &&
            (context_id0 & AMDGPU_FENCE_MES_QUEUE_FLAG))
-               return 0;
+               return false;
 
        pr_debug("client id 0x%x, source id %d, vmid %d, pasid 0x%x. raw data:\n",
                 client_id, source_id, vmid, pasid);
@@ -258,7 +258,7 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
 
        /* If there is no valid PASID, it's likely a bug */
        if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt"))
-               return 0;
+               return false;
 
        /* Interrupt types we care about: various signals and faults.
         * They will be forwarded to a work queue (see below).