drm/imx/dcss: fix coccinelle warning
authorLaurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Thu, 5 Nov 2020 14:01:26 +0000 (16:01 +0200)
committerLucas Stach <l.stach@pengutronix.de>
Thu, 26 Nov 2020 10:29:40 +0000 (11:29 +0100)
This small patch fixes a warning that I got while running coccinelle:

  CHECK   drivers/gpu/drm/imx/dcss/dcss-plane.c
  drivers/gpu/drm/imx/dcss/dcss-plane.c:107:21-23: WARNING !A || A && B is equivalent to !A || B

Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20201105140127.25249-3-laurentiu.palcu@oss.nxp.com
drivers/gpu/drm/imx/dcss/dcss-plane.c

index 46a188dd02adc43d871c114945ca4f663a069e56..5db093aada2fe6bc707cc179fa11f3ed3be4005e 100644 (file)
@@ -103,8 +103,7 @@ static bool dcss_plane_can_rotate(const struct drm_format_info *format,
                                  bool mod_present, u64 modifier,
                                  unsigned int rotation)
 {
-       bool linear_format = !mod_present ||
-                            (mod_present && modifier == DRM_FORMAT_MOD_LINEAR);
+       bool linear_format = !mod_present || modifier == DRM_FORMAT_MOD_LINEAR;
        u32 supported_rotation = DRM_MODE_ROTATE_0;
 
        if (!format->is_yuv && linear_format)