media: atomisp: add more comments about frame allocation
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 27 May 2020 12:21:26 +0000 (14:21 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Jun 2020 16:14:40 +0000 (18:14 +0200)
The frame allocation logic happens differently for userptr
or normal mmap. On a quick look, this sounded to be unbalanced,
but the logic should actually work for both cases.

Add an extra comment to reflect it.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_ioctl.c

index 8783d4b..765e1a8 100644 (file)
@@ -1052,7 +1052,7 @@ int __atomisp_reqbufs(struct file *file, void *fh,
        atomisp_alloc_css_stat_bufs(asd, stream_id);
 
        /*
-        * for user pointer type, buffers are not really allcated here,
+        * for user pointer type, buffers are not really allocated here,
         * buffers are setup in QBUF operation through v4l2_buffer structure
         */
        if (req->memory == V4L2_MEMORY_USERPTR)
@@ -1225,6 +1225,10 @@ static int atomisp_qbuf(struct file *file, void *fh, struct v4l2_buffer *buf)
                buf->flags |= V4L2_BUF_FLAG_MAPPED;
                buf->flags |= V4L2_BUF_FLAG_QUEUED;
                buf->flags &= ~V4L2_BUF_FLAG_DONE;
+
+               /*
+                * For mmap, frames were allocated at request buffers
+                */
        }
 
 done: