clk: versatile: Add of_node_put() in cm_osc_setup()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Sun, 4 Aug 2019 16:34:44 +0000 (22:04 +0530)
committerStephen Boyd <sboyd@kernel.org>
Wed, 7 Aug 2019 22:25:25 +0000 (15:25 -0700)
In function cm_osc_setup, variable parent takes the value returned by
of_get_parent, which gets a node but does not put it. If parent is not
put before it goes out of scope, it may cause a memory leak.
Hence put parent before the function terminates.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lkml.kernel.org/r/20190804163445.6862-1-nishkadg.linux@gmail.com
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/versatile/clk-versatile.c

index 90bb0b0..fd54d5c 100644 (file)
@@ -70,6 +70,7 @@ static void __init cm_osc_setup(struct device_node *np,
                        return;
                }
                cm_base = of_iomap(parent, 0);
+               of_node_put(parent);
                if (!cm_base) {
                        pr_err("could not remap core module base\n");
                        return;