mtd: spi-nor: core: Add erase size check for erase command initialization
authorTakahiro Kuwano <Takahiro.Kuwano@infineon.com>
Fri, 2 Oct 2020 05:18:02 +0000 (14:18 +0900)
committerTudor Ambarus <tudor.ambarus@microchip.com>
Fri, 5 Feb 2021 13:20:55 +0000 (15:20 +0200)
Even if erase type is same as previous region, erase size can be different
if the previous region is overlaid region. Since 'region->size' is assigned
to 'cmd->size' for overlaid region, comparing 'erase->size' and 'cmd->size'
can detect previous overlaid region.

Fixes: 5390a8df769e ("mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories")
Cc: stable@vger.kernel.org
Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
[ta: Add Fixes tag and Cc to stable]
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/13d47e8d8991b8a7fd8cc7b9e2a5319c56df35cc.1601612872.git.Takahiro.Kuwano@infineon.com
drivers/mtd/spi-nor/core.c

index d25d8b0..b17facc 100644 (file)
@@ -1516,6 +1516,7 @@ static int spi_nor_init_erase_cmd_list(struct spi_nor *nor,
                        goto destroy_erase_cmd_list;
 
                if (prev_erase != erase ||
+                   erase->size != cmd->size ||
                    region->offset & SNOR_OVERLAID_REGION) {
                        cmd = spi_nor_init_erase_cmd(region, erase);
                        if (IS_ERR(cmd)) {