Staging: rtl8192e: Added braces around else
authorFelix Schlepper <f3sch.git@outlook.com>
Fri, 1 Jul 2022 09:24:52 +0000 (11:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Jul 2022 12:25:46 +0000 (14:25 +0200)
This addresses two issues raised by checkpatch.pl:

     $ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
     CHECK: braces {} should be used on all arms of this statement
     CHECK: Unbalanced braces around else statement

The coding style rule with not using unnecessary braces around if/else
does not apply if only one branch is a single statement.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
Link: https://lore.kernel.org/r/651f51d9f92e8a445ceaf9f2073f16dd10458a74.1656667089.git.f3sch.git@outlook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_wx.c

index db076e8..b949e72 100644 (file)
@@ -304,8 +304,9 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
                        netdev_dbg(ieee->dev,
                                   "Disabling encryption on key %d.\n", key);
                        lib80211_crypt_delayed_deinit(&ieee->crypt_info, crypt);
-               } else
+               } else {
                        netdev_dbg(ieee->dev, "Disabling encryption.\n");
+               }
 
                /* Check all the keys to see if any are still configured,
                 * and if no key index was provided, de-init them all
@@ -724,8 +725,9 @@ int rtllib_wx_set_auth(struct rtllib_device *ieee,
                } else if (data->value & IW_AUTH_ALG_LEAP) {
                        ieee->open_wep = 1;
                        ieee->auth_mode = 2;
-               } else
+               } else {
                        return -EINVAL;
+               }
                break;
 
        case IW_AUTH_WPA_ENABLED: