Revert "[lldb] Refactor SBFileSpec::GetDirectory"
authorMuhammad Omair Javaid <omair.javaid@linaro.org>
Mon, 15 May 2023 10:25:52 +0000 (14:25 +0400)
committerMuhammad Omair Javaid <omair.javaid@linaro.org>
Mon, 15 May 2023 18:49:00 +0000 (22:49 +0400)
This reverts commit 2bea2d7b070dc5df723ce2b92dbc654b8bb1847e.

It introduced following failures on buildbot lldb-aarch64-windows:

lldb-api :: functionalities/process_save_core/TestProcessSaveCore.py
lldb-api :: python_api/symbol-context/TestSymbolContext.py

Differential Revision: https://reviews.llvm.org/D149625

lldb/source/API/SBFileSpec.cpp

index 8668b64..a7df9af 100644 (file)
@@ -114,7 +114,9 @@ const char *SBFileSpec::GetFilename() const {
 const char *SBFileSpec::GetDirectory() const {
   LLDB_INSTRUMENT_VA(this);
 
-  return m_opaque_up->GetDirectory().GetCString();
+  FileSpec directory{*m_opaque_up};
+  directory.ClearFilename();
+  return directory.GetPathAsConstString().GetCString();
 }
 
 void SBFileSpec::SetFilename(const char *filename) {