i40e: Fix memory leak in i40e_probe
authorKeita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Fri, 30 Oct 2020 07:14:30 +0000 (07:14 +0000)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 18 Feb 2021 18:03:54 +0000 (10:03 -0800)
Struct i40e_veb is allocated in function i40e_setup_pf_switch, and
stored to an array field veb inside struct i40e_pf. However when
i40e_setup_misc_vector fails, this memory leaks.

Fix this by calling exit and teardown functions.

Signed-off-by: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/i40e/i40e_main.c

index 1db482d..8491626 100644 (file)
@@ -15122,6 +15122,8 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                if (err) {
                        dev_info(&pdev->dev,
                                 "setup of misc vector failed: %d\n", err);
+                       i40e_cloud_filter_exit(pf);
+                       i40e_fdir_teardown(pf);
                        goto err_vsis;
                }
        }