radv: fix clearing images with vkCmdClear{Color,DepthStencil}Image()
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Tue, 5 Jan 2021 07:36:59 +0000 (08:36 +0100)
committerMarge Bot <eric+marge@anholt.net>
Tue, 5 Jan 2021 09:46:01 +0000 (09:46 +0000)
The image aspects field is actually never set and we should use the
range aspect anyways.

Fixes: 1a7b7b17ad0 ("radv: avoid oob read during clear")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8324>

src/amd/vulkan/radv_meta_clear.c

index 3ac9aa7..ec5435c 100644 (file)
@@ -2206,7 +2206,7 @@ radv_cmd_clear_image(struct radv_cmd_buffer *cmd_buffer,
        VkFormat format = image->vk_format;
        VkClearValue internal_clear_value;
 
-        if (image->aspects & VK_IMAGE_ASPECT_COLOR_BIT)
+        if (ranges->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT)
                 internal_clear_value.color = clear_value->color;
         else
                 internal_clear_value.depthStencil = clear_value->depthStencil;