virtio: decrement vq->inuse in virtqueue_discard()
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 15 Aug 2016 12:54:16 +0000 (13:54 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 23 Aug 2016 16:20:24 +0000 (19:20 +0300)
virtqueue_discard() moves vq->last_avail_idx back so the element can be
popped again.  It's necessary to decrement vq->inuse to avoid "leaking"
the element count.

Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/virtio.c

index 6105c6e..74c085c 100644 (file)
@@ -268,6 +268,7 @@ void virtqueue_discard(VirtQueue *vq, const VirtQueueElement *elem,
                        unsigned int len)
 {
     vq->last_avail_idx--;
+    vq->inuse--;
     virtqueue_unmap_sg(vq, elem, len);
 }