[M108 Migration] Remove EWK_BRINGUP from ewk_settings.cc 74/288674/3
authorayush.k123 <ayush.k123@samsung.com>
Tue, 21 Feb 2023 09:10:32 +0000 (14:40 +0530)
committerAyush Kumar <ayush.k123@samsung.com>
Thu, 23 Feb 2023 12:53:40 +0000 (12:53 +0000)
This patch removes EWK_BRINGUP and unused code from ewk_settings.cc.

References: https://review.tizen.org/gerrit/280785/

Change-Id: I7950338a8fb06b8d07e82f991d81f72185227cec
Signed-off-by: Ayush Kumar <ayush.k123@samsung.com>
tizen_src/ewk/efl_integration/public/ewk_settings.cc

index ea62255..d406e3f 100644 (file)
@@ -40,18 +40,6 @@ void ewkUpdateWebkitPreferences(Evas_Object *ewkView)
   EWebView* impl = EWebView::FromEvasObject(ewkView);
   assert(impl);
 
-  bool autoSelectWord = ewk_settings_select_word_automatically_get(impl->GetSettings());
-  // TODO(sns.park) : remove dependency to chromium internals
-  if(autoSelectWord){
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-    ui::GestureConfiguration::set_double_tap_to_zoom_enabled(false);
-#endif
-  }
-  else{
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-    ui::GestureConfiguration::set_double_tap_to_zoom_enabled(true);
-#endif
-  }
   impl->UpdateWebKitPreferences();
 }
 
@@ -59,26 +47,14 @@ void ewkUpdateWebkitPreferences(Evas_Object *ewkView)
 
 Eina_Bool ewk_settings_fullscreen_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
 {
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-#pragma message "[M38] fullscreen_enabled flag has been deleted from webpreference.h"
-  EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
-  settings->getPreferences().fullscreen_enabled = enable;
-  ewkUpdateWebkitPreferences(settings->getEvasObject());
-  return EINA_TRUE;
-#else
+  LOG_EWK_API_MOCKUP("Not Supported by chromium");
   return EINA_FALSE;
-#endif
 }
 
 Eina_Bool ewk_settings_fullscreen_enabled_get(const Ewk_Settings* settings)
 {
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-#pragma message "[M38] fullscreen_enabled flag has been deleted from webpreference.h"
-  EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
-  return settings->getPreferences().fullscreen_enabled;
-#else
+  LOG_EWK_API_MOCKUP("Not Supported by chromium");
   return EINA_FALSE;
-#endif
 }
 
 Eina_Bool ewk_settings_javascript_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
@@ -242,12 +218,8 @@ Eina_Bool ewk_settings_private_browsing_enabled_get(const Ewk_Settings* settings
 
 Eina_Bool ewk_settings_editable_link_behavior_set(Ewk_Settings* settings, Ewk_Editable_Link_Behavior behavior)
 {
-  EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-  settings->getPreferences().editable_link_behavior = static_cast<webkit_glue::EditableLinkBehavior>(behavior);
-#endif
-  ewkUpdateWebkitPreferences(settings->getEvasObject());
-  return EINA_TRUE;
+  LOG_EWK_API_MOCKUP("Not Supported by chromium");
+  return EINA_FALSE;
 }
 
 Eina_Bool ewk_settings_load_remote_images_set(Ewk_Settings* settings, Eina_Bool loadRemoteImages)
@@ -335,9 +307,7 @@ Eina_Bool ewk_settings_link_effect_enabled_get(const Ewk_Settings* settings)
 Eina_Bool ewk_settings_uses_encoding_detector_set(Ewk_Settings* settings, Eina_Bool use)
 {
   EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
   settings->getPreferences().uses_encoding_detector = use;
-#endif
   ewkUpdateWebkitPreferences(settings->getEvasObject());
   return EINA_TRUE;
 }
@@ -345,11 +315,7 @@ Eina_Bool ewk_settings_uses_encoding_detector_set(Ewk_Settings* settings, Eina_B
 Eina_Bool ewk_settings_uses_encoding_detector_get(const Ewk_Settings* settings)
 {
   EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
   return settings->getPreferences().uses_encoding_detector;
-#else
-  return EINA_FALSE;
-#endif
 }
 
 Eina_Bool ewk_settings_default_keypad_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
@@ -566,22 +532,14 @@ Eina_Bool ewk_settings_select_word_automatically_get(const Ewk_Settings* setting
 
 Ewk_List_Style_Position ewk_settings_initial_list_style_position_get(const Ewk_Settings* settings)
 {
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-  EINA_SAFETY_ON_NULL_RETURN_VAL(settings, EWK_LIST_STYLE_POSITION_OUTSIDE);
-  return static_cast<Ewk_List_Style_Position>(settings->getPreferences().initial_list_style_position);
-#else
+  LOG_EWK_API_MOCKUP("Not Supported by chromium");
   return EWK_LIST_STYLE_POSITION_OUTSIDE;
-#endif
 }
 
 Eina_Bool ewk_settings_initial_list_style_position_set(Ewk_Settings* settings, Ewk_List_Style_Position style)
 {
-  EINA_SAFETY_ON_NULL_RETURN_VAL(settings, EINA_FALSE);
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-  settings->getPreferences().initial_list_style_position = static_cast<content::ListStylePosition>(style);
-#endif
-  ewkUpdateWebkitPreferences(settings->getEvasObject());
-  return EINA_TRUE;
+  LOG_EWK_API_MOCKUP("Not Supported by chromium");
+  return EINA_FALSE;
 }
 
 Eina_Bool ewk_settings_webkit_text_size_adjust_enabled_set(Ewk_Settings* settings, Eina_Bool enabled)
@@ -596,20 +554,13 @@ Eina_Bool ewk_settings_webkit_text_size_adjust_enabled_set(Ewk_Settings* setting
 // TODO: this API is gone in newer versions of webkit-efl
 void ewk_settings_detect_contents_automatically_set(Ewk_Settings* settings, Eina_Bool enable)
 {
-  EINA_SAFETY_ON_NULL_RETURN(settings);
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-  settings->setDetectContentsEnabled(enable);
-#endif
+  LOG_EWK_API_MOCKUP("Not Supported by chromium");
 }
 
 Eina_Bool ewk_settings_detect_contents_automatically_get(const Ewk_Settings* settings)
 {
-  EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-  return settings->getDetectContentsEnabled();
-#else
+  LOG_EWK_API_MOCKUP("Not Supported by chromium");
   return EINA_FALSE;
-#endif
 }
 
 void ewk_settings_cache_builder_enabled_set(Ewk_Settings *settings, Eina_Bool enabled)
@@ -671,51 +622,6 @@ Eina_Bool ewk_settings_encoding_detector_enabled_set(Ewk_Settings* settings, Ein
   return EINA_FALSE;
 }
 
-namespace {
-#define EXTRA_FEATURE_FUNCTIONS(VALNAME) \
-  void Ewk_Extra_Feature_Set_ ## VALNAME(Ewk_Settings* settings, Eina_Bool value) \
-  { \
-    EINA_SAFETY_ON_NULL_RETURN(settings); \
-    settings->set ## VALNAME ## Enabled(value == EINA_TRUE); \
-  } \
-  Eina_Bool Ewk_Extra_Feature_Get_ ## VALNAME(const Ewk_Settings* settings) \
-  { \
-    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, EINA_FALSE); \
-    return settings->get ## VALNAME ## Enabled() ? EINA_TRUE : EINA_FALSE; \
-  }
-
-#define EWK_EXTRA_FEATURE(NAME, VALNAME) {NAME, Ewk_Extra_Feature_Set_## VALNAME, Ewk_Extra_Feature_Get_ ## VALNAME}
-
-  EXTRA_FEATURE_FUNCTIONS(LongPress)
-  EXTRA_FEATURE_FUNCTIONS(LinkMagnifier)
-  EXTRA_FEATURE_FUNCTIONS(DetectContents)
-  EXTRA_FEATURE_FUNCTIONS(WebLogin)
-  EXTRA_FEATURE_FUNCTIONS(DoubleTap)
-  EXTRA_FEATURE_FUNCTIONS(Zoom)
-  EXTRA_FEATURE_FUNCTIONS(OpenPanel)
-  EXTRA_FEATURE_FUNCTIONS(AllowRestrictedURL)
-  EXTRA_FEATURE_FUNCTIONS(URLBarHide)
-
-  void Ewk_Extra_Feature_Set_ViewportQuirk(Ewk_Settings* settings, Eina_Bool value)
-  {
-    EINA_SAFETY_ON_NULL_RETURN(settings);
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-    settings->getPreferences().viewport_meta_non_user_scalable_quirk = value;
-#endif
-    ewkUpdateWebkitPreferences(settings->getEvasObject());
-  }
-
-  Eina_Bool Ewk_Extra_Feature_Get_ViewportQuirk(const Ewk_Settings* settings)
-  {
-#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
-    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
-    return settings->getPreferences().viewport_meta_non_user_scalable_quirk;
-#else
-    return EINA_FALSE;
-#endif
-  }
-}
-
 Eina_Bool ewk_settings_extra_feature_get(const Ewk_Settings* settings, const char* feature)
 {
   EINA_SAFETY_ON_NULL_RETURN_VAL(settings, EINA_FALSE);