perf evsel: Dummy events never triggers, no need to ask for PERF_SAMPLE_BRANCH_STACK
authorIan Rogers <irogers@google.com>
Fri, 8 May 2020 17:08:03 +0000 (14:08 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 28 May 2020 13:03:25 +0000 (10:03 -0300)
A dummy event never triggers any actual counter and therefore cannot be
used with branch_stack

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20200422173615.59436-1-irogers@google.com
[ split from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/evsel.c

index 28683b0eb7382e0f729dd71a0092e19fd39bd874..a2397ca4d57aa8ef5306f4a94093663fd70deaf0 100644 (file)
@@ -1153,11 +1153,14 @@ void evsel__config(struct evsel *evsel, struct record_opts *opts,
        }
 
        /*
+        * A dummy event never triggers any actual counter and therefore
+        * cannot be used with branch_stack.
+        *
         * For initial_delay, a dummy event is added implicitly.
         * The software event will trigger -EOPNOTSUPP error out,
         * if BRANCH_STACK bit is set.
         */
-       if (opts->initial_delay && is_dummy_event(evsel))
+       if (is_dummy_event(evsel))
                evsel__reset_sample_bit(evsel, BRANCH_STACK);
 }